Feat/email deletion #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended autocompletion: - `search_terms_list` now also contains `is:`, `to:`, `from`, `body:` and the logical expressions `and`, `or`, `not`. - Added autocomplete functionality for `mimetype:`, `to:`, `from:`, `path:`, and `folder:` search. - Extended `:ComposeMail` to optionally accept recipient, incl. autocomplete Key binding and visual control - Extended `:TagAdd`, `:TagRm`, and `:TagToggle` to accept line ranges - Extended key bindings `+`, `-`, `=`, `a`, `A`, and `x` in the threads view to the visual mode - Added `f` key binding (visual mode and normal mode) in the threads view to toggle the `flagged` tag
- Adds the command `:DelThread` in the thread view. This command adds the tag "del" to the emails. This command also works in visual mode, so multiple threads can be deleted simultaneously. - Binds `:DelThread` to `dd` in normal mode and `d` in visual mode. - Update the hint text to display `dd` key. - Binds `D` to the function call `purge_del()`. With this, emails marked to be deleted are removed from the drive. After hitting `D`, the user sees all emails marked to be delete. Puring is then initiated by hitting `DD` (see line 8 in `lua/notmuch/delete.lua`)
Owner
|
Hey @baumea , Thanks for another PR, I really like the concept of this change and started using it myself for bulk deleting spam email! I went ahead and merged this to Made some fixes as mentioned in #10 as well:
If you have the time, I'd like to brainstorm how to improve the deletion workflow a bit more. Some comments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on PR #10, but is logically independent.
:DelThreadin the thread view. This command addsthe tag "del" to the emails. This command also works in visual mode,
so multiple threads can be deleted simultaneously.
:DelThreadtoddin normal mode anddin visual mode.ddkey.Dto the function callpurge_del(). With this, emails markedto be deleted are removed from the drive. After hitting
D, the usersees all emails marked to be delete. Puring is then initiated by
hitting
DD(see line 8 inlua/notmuch/delete.lua)